Adapt golden testing framework from pub client #1520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
While the filenames with spaces are probably a non-issue, shouldn't we rather have |
Contributor
Author
Possibly. The spaces have caused no problem in the pub client... |
Collaborator
I'm not worried about problems, more about consistency... to me these filenames feel a bit off compared to the rest, where we don't use spaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(adapted from https://github.com/dart-lang/pub/blob/master/test/golden_file.dart)
With this:
_WRITE_GOLDENS=TRUE.